Omniscia Bware Labs Audit
BwareBridgeProxy Manual Review Findings
BwareBridgeProxy Manual Review Findings
BBP-01M: Potentially Misbehaving Name
| Type | Severity | Location |
|---|---|---|
| Logical Fault | Minor | BwareBridgeProxy.sol:L390-L392 |
Description:
The productName of ProductProxy is set as zero (0x0) which can lead to unintended behaviour, such as reading the default storage slot of a mapping entry.
Example:
ico/contracts/BwareBridgeProxy.sol
390function productName() virtual public pure returns (bytes32) {391 return 0x0;392}Recommendation:
We advise this to be set to a non-zero value that is sensible for the implementation.
Alleviation:
The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.