Omniscia Bware Labs Audit
BwareBridge Static Analysis Findings
BwareBridge Static Analysis Findings
BBE-01S: Data Location Optimization
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | Informational | BwareBridge.sol:L950 |
Description:
The increaseAuthQuota function is set as external yet contains memory array arguments.
Example:
ico/contracts/BwareBridge.sol
950function increaseAuthQuota(address[] memory signers, uint256[] memory increments) virtual external onlyOwner {Recommendation:
We advise them to be set as calldata greatly optimizing the gas cost of the function.
Alleviation:
The data location of the arguments was correctly set to calldata greatly optimizing its gas cost.
BBE-02S: Nonstandard Naming Conventions
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | BwareBridge.sol:L736-L938 |
Description:
The variable naming conventions of the MultiSigUpgradeable contract are non-standard and do not conform to the [official Solidity style guide].
Example:
ico/contracts/BwareBridge.sol
744// pointer used to find a free slot in owner-index mappings.745uint256 private _owner_count;746mapping (address => uint256) private _get_owner_index;747mapping (uint256 => address) private _get_owner_addr;Recommendation:
We advise them to be adjusted to fall in line with the standard and become more legible to external readers of the codebase.
Alleviation:
The naming conventions across the codebase were refactored thus alleviating this exhibit.