Omniscia Glimpse Audit
GLMS_BSC Manual Review Findings
GLMS_BSC Manual Review Findings
GLM-01M: Inconsistent GSN Conformity
Type | Severity | Location |
---|---|---|
Standard Conformity | Informational | GLMS_BSC.sol:L40, L95 |
Description:
The batchTransfer
function does not conform to the _msgSender()
convention the rest of the contract does.
Example:
contracts/GLMS_BSC.sol
38function batchTransfer(TransferData[] calldata data) external {39 for (uint i = 0; i < data.length; i++) {40 _transfer(msg.sender, data[i].recipient, data[i].amount);41 }42}
Recommendation:
We strongly recommend the _msgSender()
getter function to be utilized to ensure potential conformity with the GSN in the future.
Alleviation:
The batchTransfer
custom function was adapted to be GSN compliant according to our recommendation.