GovernanceV2Facet Manual Review Findings

GVF-01M: Function Signature Collision

Description:

The updateMember function signature of GovernanceV2Facet collides with the same implementation existing in GovernanceFacet. This will lead to only one function existing within the Diamond standard implementation.

Example:

Copy
21function updateMember(
22    address _account,
23    address _accountAdmin,
24    bool _status
25) external override {

Recommendation:

We advise this trait to be assessed and if deemed desired to be explicitly stated in the code as this is a common pitfall of the Diamond standard. We have set the severity of this finding to minor as we expect this to be desired behaviour of Hashport.

Alleviation:

Proper documentation was introduced by the LimeChain team to the function indicating that the function is indeed meant to replace the "v1" implementation and addressing this exhibit.