Omniscia Alliance Block Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the update of the liquidity staking system.
As the delta at hand implements a new reward addition mechanism, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a major vulnerability within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the XYZ team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the autostake and pool features as they remain improperly documented from the previous audit.
A total of 3 findings were identified over the course of the manual review of which 2 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
CRP-01M | Major | Yes | Invalid Reward Addition |
CRF-01M | Minor | Yes | Schedule & Reward Desynchronization |