Omniscia Alliance Block Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the payment gateway of Alliance Block.
As the project at hand implements a transactional access scheme, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the gateway's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple DEX related discrepancies within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Alliance Block team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the test suites of the project to be fleshed out to ensure calculations are performed properly as some of the findings we observed could have been identified in test suites.
A total of 15 findings were identified over the course of the manual review of which 7 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
PPL-01M | Major | Yes | Flash Loan Susceptibility |
PPL-02M | Medium | Yes | Incorrect Uniswap Output Calculation |
PPL-03M | Medium | Yes | Inexistent User Slippage Validation |
PPL-04M | Medium | Yes | On-Chain Slippage Logical Fallacy |
PPL-05M | Minor | Yes | Inexistent Minimum Subscription |
PPL-06M | Minor | Yes | Inexistent Price Range Bounds |
PPL-07M | Minor | Yes | Inexistent Slippage Bound Evaluation |