Omniscia AmpleSense Audit

Code Style

Code Style

During the manual portion of the audit, we identified 14 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
AMP-01CInformationalYesInexistent Variable Visibility Specifiers
AMP-02CInformationalYesRedundant Function Block
AMP-03CInformationalYesVariable Mutability Specifier
AVT-01CInformationalYesNon-Standard ERC-20 Transfer Invocation
AVT-02CInformationalYesVariable Mutability Specifiers
BTR-01CInformationalYesDeprecated Representation Style
BTR-02CInformationalYesInexistent Variable Visibility Specifiers
BTR-03CInformationalYesVariable Mutability Specifiers
DIS-01CInformationalYesInefficient Code Implementation
DIS-02CInformationalYesInexistent Variable Visibility Specifier
DIS-03CInformationalYesVariable Mutability Specifiers
PVT-01CInformationalYesInexistent Variable Visibility Specifiers
SER-01CInformationalYesVariable Mutability Specifiers
SEC-01CInformationalYesVariable Mutability Specifiers

Prev

Manual Review

Next

BalancerTrader.sol (BTR-S)