Omniscia Beanstalk Audit

InitBip5 Static Analysis Findings

InitBip5 Static Analysis Findings

IB5-01S: Illegible Value Literals

TypeSeverityLocation
Code StyleInitBip5.sol:L25, L26

Description:

The linked value literals represent a very large number but do so illegibly.

Example:

protocol/contracts/farm/init/InitBip5.sol
24function init() external {
25 IBS(address(this)).createFundraiser(payee, token, 140000000000);
26 IBean(address(bean)).mint(payee, 15000000000);
27}

Recommendation:

We advise the special underscore (_) character to be utilised as a separator per thousand units to better represent the linked values (i.e. 10000 becomes 10_000).

Alleviation:

The value representation style was adjusted to contain the underscore separator character and comments were additionally introduced indicating what the exact values are meant to be alleviating this exhibit.