Omniscia Congruent Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the reward token staking mechanism interfacing with Convex Finance.
As the project at hand implements a reward token staking mechanism integrating with an external protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within both the external and local protocol specifications.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a major vulnerability arising from improper upgrade-ability within the system which could have had severe ramifications to its overall operation, however, it was conveyed ahead of time to the Congruent team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 11 findings were identified over the course of the manual review of which 9 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
MCF-01M | ![]() | ![]() | Inexistent Validation of Minted Amount |
MCF-02M | ![]() | ![]() | Inexistent Update of Existing Pools |
MCF-03M | ![]() | ![]() | Overly Centralized Operator Control |
MCF-04M | ![]() | ![]() | Inexistent Initialization of UUPS Dependency |
RDR-01M | ![]() | ![]() | Inexistent Initialization of UUPS Dependency |
CRV-01M | ![]() | ![]() | Centralized Token Ownership |
CRV-02M | ![]() | ![]() | Inexistent Validation of Mint Operation |
CRD-01M | ![]() | ![]() | Overly Centralized Reward Lifecycle Management |
CRD-02M | ![]() | ![]() | Deprecated Approval Paradigm |