Omniscia Criptan Audit
Wallet Static Analysis Findings
Wallet Static Analysis Findings
WAL-01S: Deprecated Native Asset Transfer
Type | Severity | Location |
---|---|---|
Language Specific | ![]() | Wallet.sol:L42 |
Description:
The transfer
member exposed by payable
address types has been deprecated as it does not reliably execute and can fail in future updates of the EVM as it forwards a fixed gas stipend which is not compatible with gas cost EIP upgrades such as EIP-2929.
Example:
contracts/Wallet.sol
42master().transfer(balance);
Recommendation:
We advise a safe wrapper library to be utilized instead such as the sendValue
function of the Address
library by OpenZeppelin which is guaranteed to execute under all circumstances.
Alleviation:
The sendValue
function of the Address
library by OpenZeppelin is now properly utilized in the codebase.