Omniscia Faculty Group Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the liquidity mining system of the Faculty Group.

As the project at hand implements a liquidity mining system akin to SushiSwap, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a potential deviation in calculations within the system which can lead to miscalculated rewards, however, it was conveyed ahead of time to the Faculty Group team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a good extent with no particular points of interest left undocumented.

A total of 3 findings were identified over the course of the manual review of which 2 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
LMG-01MMediumNoIncorrect Decimal Assumption
LMG-02MMinorYesInconsistent Paradigm