ChildFaithTribe Code Style Findings

CFT-01C: Redundant Visibility Specifiers

Description:

The linked variables are declared as public yet are meant to be utilized as internally accessible variables.

Example:

Copy
12bytes32 public constant SNAPSHOT_ROLE = keccak256("SNAPSHOT_ROLE");
13bytes32 public constant DEPOSITER_ROLE = keccak256("DEPOSITER_ROLE");

Recommendation:

We advise them to be set as either private or internal depending on their intended scope.

Alleviation:

Both variables are now set as private optimizing the bytecode of the contract.