Omniscia Flourishing Capital Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the EIP-20 token implementation of Flourishing Capital.
As the project at hand implements an EIP-20 token with a vesting schedule, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the vesting system's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed two significant misbehaviours within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Flourishing Capital team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the test suites of the project to be expanded to encompass more edge cases.
A total of 11 findings were identified over the course of the manual review of which 8 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
ERC-01M | Major | Yes | Breaking EIP-20 Approval Adaptation |
ERC-02M | Major | Yes | Incorrect Schedule Retrieval |
ERC-03M | Medium | Yes | Inexplicable Reset Potential |
ERC-04M | Minor | Yes | Deviation of Specification |
ERC-05M | Minor | Yes | Inexistent Overriddance of Burn Functionality |
ERC-06M | Minor | No | Ungraceful Vesting Error Handling |
ERC-07M | Minor | Yes | Ungraceful Whitelist Error Handling |
FAI-01M | Medium | No | Inherent Race Condition |