Omniscia Hot Cross Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the Cross Pool.

As the project at hand implements a token staking implementation, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed certain discrepancies within the system which can have minimal impact to the system but should be alleviated to ensure the codebase conforms to the latest security principles and guidelines.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.

A total of 10 findings were identified over the course of the manual review of which 5 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
CPL-01MMinorYesInapplicacy of Checks-Effects-Interactions Pattern
CPL-02MMinorYesInexistent Input Sanitization
CPL-03MMinorYesPotential Desynchronization of Rewards
CPL-04MMinorYesRedundant Duplicate Invocation
RVT-01MMinorYesUnsanitized Input