Omniscia Hot Cross Audit
HotCross Code Style Findings
HotCross Code Style Findings
HCS-01C: Inexistent Visibility Specifier
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | HotCross.sol:L8 |
Description:
The MILLION contract constant contains no visibility specifier set.
Example:
contracts/token/HotCross.sol
8uint256 constant MILLION = (10**6) * 10**uint256(18);Recommendation:
We advise one to be explicitly specified to ensure no compilation discrepancy may arise in the future. Additionally, we advise it to be better depicted as 1_000_000 * 10**uint256(18).
Alleviation:
Although its depiction was changed to 1_000_000, its visibility specifier still remains unset.