PACTTimelock Manual Review Findings

PAT-01M: Potentially Harmful Minimum Delay

Type	Severity	Location
Standard Conformity		PACTTimelock.sol:L38

Description:

The minimum delay set for a proposal's execution is 1 hours which is considered minimum in terms of operational standards.

Impact:

A small delay between a proposal's acceptance and a proposal's execution may lead to little time for proper protocol upgrades to take place in other places of the ecosystem such as the front-end and back-end deployments.

Example:

Copy
38uint256 public constant MINIMUM_DELAY = 1 hours;

Recommendation:

We advise at least a minimum of 8 hours to be set to ensure that there is reactionary time for the Impact Market protocol to assess a proposal's impact.

Alleviation:

The minimum delay for a proposal's execution has been updated to 8 hours rendering it adequate.