Omniscia NFTFY Audit

Code Style

Code Style

During the manual portion of the audit, we identified 24 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
NFT-01CInformationalNoMislocated Input Sanitization
NFT-02CInformationalNoInefficient mapping Relations
NFT-03CInformationalYesVariable Visibility Specifiers
SER-01CInformationalNoRedundant Return Variable
SHA-01CInformationalYesRedundant approve Invocation
SHA-02CMinorYesIneffectual Event Emittances
SHA-03CInformationalNoRedundant assert
SHA-04CInformationalYesVariable Mutability Specifiers
SHA-05CInformationalYesInexistent Error Messages
SHA-06CInformationalYesInefficient Event Arguments
WRA-01CInformationalNoNon-Standard Naming Convention
WRA-02CInformationalYesInexistent Error Messages
WRA-03CInformationalNoUnconditional Execution of Setter
WRA-04CInformationalNoRedundant Return Variable

Prev

Manual Review

Next

Shares.sol (SHA-S)