Omniscia Parabola Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Parabola Finance's protocol.
As the project at hand implements mutliple DeFi components including a DEX and staking contract, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed two potential circumvention vulnerabilities within the system's novel staking mechanism which could have had moderate ramifications to its overall operation, however, they were conveyed ahead of time to the Parabola Finance team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a good extent, however, we advise documentation to be expanded on certain complex points such as the unique week = 0
condition within the MultiStakingRewards
contract.
A total of 13 findings were identified over the course of the manual review of which 7 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
DAS-01M | Medium | No | Dangerous Simplification of LP Evaluation |
DAS-02M | Minor | No | Inexplicable Constant Return |
LPT-01M | Minor | No | Deviation of Original Codebase |
MSR-01M | Medium | No | Potential Circumvention of Lock Time |
MSR-02M | Minor | Yes | Inexistent Validation of Proper Withdrawal |
MSR-03M | Minor | No | Potentially Incorrect Multiplier Sanitization |
PTN-01M | Medium | No | Insecure Elliptic Curve Recovery Mechanism |