Omniscia Pirex Audit

Multi Token Convex Wrapper Security Audit

Audit Overview

We were tasked with performing an audit of the Pirex codebase and in particular their multi-token Convex wrapper ecosystem permitting users to wrap their Convex tokens based on voting epochs.

Over the course of the audit, we identified some important flaws relating to the mathematical calculations around rewards & redemptions as well as certain blockchain-specific misbehaviours that could negatively impact the project and its users.

We advise the Pirex team to closely evaluate all minor-and-above findings identified in the report and promptly remediate them as well as consider all optimizational exhibits identified in the report.

Post-Audit Conclusion

The Pirex team has provided an alleviation for each exhibit in the form of an extensive PDF outlining the rationale behind some of the exhibits that required no action.

We re-assessed all exhibits based on newfound information provided to us by the Pirex team and have updated each finding's status accordingly. Overall, all findings have either been dealt with or sufficiently acknowledged.

Contracts Assessed

Files in ScopeRepositoryCommit(s)
ERC1155Solmate.sol (ERC)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
ERC20SnapshotSolmate.sol (ERS)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
ERC1155PresetMinterSupply.sol (ERP)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
FixedPointMathLib.sol (FPM)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
PxCvx.sol (PCX)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
PirexCvx.sol (PCV)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
PirexFees.sol (PFS)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
PirexCvxConvex.sol (PCC)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317
UnionPirexVault.sol (UPV)pirex0200b31558,
032604740a,
968a2bd187,
0c15e0adb7,
9468ac0317

Audit Synopsis

SeverityIdentifiedAlleviatedPartially AlleviatedAcknowledged
1100
7502
9702
9702

During the audit, we filtered and validated a total of 2 findings utilizing static analysis tools as well as identified a total of 24 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they introduce potential misbehaviours of the system as well as exploits.

pie title Total Issues "Major" : 1 "Medium" : 7 "Minor" : 9 "Informational" : 9

The list below covers each segment of the audit in depth and links to the respective chapter of the report: