Omniscia Pirex Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the Pirex multi-token Convex integrating codebase.
As the project at hand implements a complex Convex-integrating wrapper protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification as well as Convex's documentation and deployed code.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple important flaws within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Pirex team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the in-line description of each of the project's token types as well as standardized documentation of external-facing functions.
A total of 24 findings were identified over the course of the manual review of which 17 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ERP-01M |  |  | Misleading Contract Documentation |
| ERS-01M |  | | Insecure Elliptic Curve Recovery Mechanism |
| PCV-01M |  | | Incorrect Proportionate Claim Mechanism |
| PCV-02M | |  | Improper Prevention of Emergency Migration |
| PCV-03M | |  | Mismatch of Maximum Redemption Time |
| PCV-04M | | | Disassociation of Votium Time Rewards |
| PCV-05M | | | Improper Sanitization of New Fee |
| PCV-06M | | | Inexistent Migration Delay |
| PCV-07M | | | Inexistent Prevention of Duplicate Entries |
| PCV-08M | | | Potentially Harmful Epoch Rounding |
| PCV-09M |  | | Unaudited External Contract Interaction |
| PCC-01M | | | Improper Adjustment of Delegation Space & Registry |
| PCC-02M | | | Incorrect Usage of Funds at Rest |
| PCC-03M | | | Unlimited CVX Allowance Centralization |
| PCC-04M | | | Unsafe & Inefficient Type |
| PFS-01M | | | Improper & Inefficient Calculation of Fees |
| PCX-01M | | | Snapshot Initialization Race Condition |