Omniscia Rari Capital Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the Compound Protocol fork of Rari.
As the project at hand is a fork of a borrowing protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's original specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed certain minor issues and ill-advised conventions within the system which we strongly urge the Rari capital to address.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the newly introduced functionality of fees.
A total of 33 findings were identified over the course of the manual review of which 24 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
CDD-01M | Minor | Yes | Inconsistent Access Control |
CE0-01M | Minor | Yes | Impossible Autonomous Deployment |
CED-01M | Minor | Yes | Inconsistent Access Control |
CON-01M | Minor | No | Potentially Misbehaving Adjustment |
CER-01M | Minor | Yes | Impossible Autonomous Deployment |
CER-02M | Minor | Yes | Potentially Breaking Functionality |
CON-01M | Minor | Yes | Inconsistent Access Control |
CON-01M | Minor | No | Potentially Misbehaving Delegation |
CTN-01M | Minor | No | Bypassable Limit Evaluation |
CTN-02M | Minor | Yes | Inconsistent Access Control |
CTN-03M | Minor | Yes | Incorrect Limit Evaluation |
CTN-04M | Minor | No | Inexistent Access Control |
CTN-05M | Minor | No | Literal enum Comparison |
CTI-01M | Minor | No | Inexistent Hardcoded Contract Address |
COM-01M | Minor | Yes | Inconsistent Access Control |
COM-02M | Minor | Yes | Inconsistent Limit Evaluation |
COM-03M | Minor | Yes | Inexistent Error Handling |
COM-04M | Minor | No | Misconstrued Data Erasure |
COM-05M | Minor | Yes | Unutilized Function Return |
CPO-01M | Minor | No | Incorrect Correlation |
CPO-02M | Medium | No | Incorrect Price Offset |
CPO-03M | Medium | No | Inconsistent Normalization |
KPO-01M | Medium | No | Inconsistent Normalization |
KPO-02M | Medium | No | Insecure Data Freshness |