Omniscia Alliance Block Audit

Liquidity Staker Update Security Audit

We were tasked with performing a second round review of the Alliance Block liquidity staking mechanism.

Over the course of the audit, we identified a major vulnerability in the way supplemental awards are added to the CompoundingRewardsPool that we urge the Alliance Block team to fix promptly.

Additionally, we identified multiple inefficiencies in the structure of the code that we strongly recommend be remediated.

Overall, we believe the codebase to be unnecessarily complex and we recommend the Alliance Block team to reconsider the code's structure and refactor it prior to deployment as in its current state it is unnecessarily convoluted.

Files in ScopeRepositoryCommit(s)
AutoStake.sol (ASE)lmaas-liquidity-staker96d4f622a6,
533b912411
AbstractPoolsFactory.sol (APF)lmaas-liquidity-staker96d4f622a6,
533b912411
Calculator.sol (CAL)lmaas-liquidity-staker96d4f622a6,
533b912411
CompoundingRewardsPool.sol (CRP)lmaas-liquidity-staker96d4f622a6,
533b912411
CompoundingRewardsPoolStaker.sol (CRS)lmaas-liquidity-staker96d4f622a6,
533b912411
CompoundingRewardsPoolFactory.sol (CRF)lmaas-liquidity-staker96d4f622a6,
533b912411
LimitedAutoStake.sol (LAS)lmaas-liquidity-staker96d4f622a6,
533b912411
LiquidityMiningCampaign.sol (LMC)lmaas-liquidity-staker96d4f622a6,
533b912411
LiquidityMiningCampaignFactory.sol (LMF)lmaas-liquidity-staker96d4f622a6,
533b912411
NonCompoundingRewardsPool.sol (NCR)lmaas-liquidity-staker96d4f622a6,
533b912411
NonCompoundingRewardsPoolFactory.sol (NCP)lmaas-liquidity-staker96d4f622a6,
533b912411
OneStakerFeature.sol (OSF)lmaas-liquidity-staker96d4f622a6,
533b912411
RewardsPoolBase.sol (RPB)lmaas-liquidity-staker96d4f622a6,
533b912411
RewardsPoolFactory.sol (RPF)lmaas-liquidity-staker96d4f622a6,
533b912411
StakeLock.sol (SLK)lmaas-liquidity-staker96d4f622a6,
533b912411
StakeLockingFeature.sol (SLF)lmaas-liquidity-staker96d4f622a6,
533b912411
StakeTransfererFeature.sol (STF)lmaas-liquidity-staker96d4f622a6,
533b912411
StakeTransfererAutoStake.sol (STA)lmaas-liquidity-staker96d4f622a6,
533b912411
StakeTransferEnabledFactory.sol (STE)lmaas-liquidity-staker96d4f622a6,
533b912411
TreasuryOperated.sol (TOD)lmaas-liquidity-staker96d4f622a6,
533b912411
ThrottledExitFeature.sol (TEF)lmaas-liquidity-staker96d4f622a6,
533b912411
TreasuryOperatedFeature.sol (TOF)lmaas-liquidity-staker96d4f622a6,
533b912411

During the audit, we filtered and validated a total of 8 findings utilizing static analysis tools as well as identified a total of 3 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they introduce potential misbehaviours of the system as well as exploits.

The list below covers each segment of the audit in depth and links to the respective chapter of the report: