Router Code Style Findings

ROU-01C: Duplication of Code

Description:

The linked code segment performs the same statements as LibDiamond's diamondStorage function.

Example:

Copy
38LibDiamond.DiamondStorage storage ds;
39bytes32 position = LibDiamond.DIAMOND_STORAGE_POSITION;
40assembly {
41    ds.slot := position
42}

Recommendation:

We advise the LibDiamond implementation to be used to ensure consistency in the codebase as well as a reduction in bytecode size.

Alleviation:

The statements were indeed replaced by an invocation of the diamondStorage function of LibDiamond.