Pioneer1Vault Code Style Findings

PVT-01C: Inexistent Variable Visibility Specifiers

Description:

The linked variables have no visibility specifiers explicitly set.

Example:

Copy
22uint256 constant SELL_THRESHOLD = 40000 * 10**9;
23uint256 constant START_PERCENT = 25;
24uint256 constant END_PERCENT = 80;
25uint256 constant CAP = 800000 * 10**9;
26IBalancerTrader public trader;

Recommendation:

We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically.

Alleviation:

The public visibility specifier was introduced for all linked variables.