Omniscia Dapp Radar Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Dapp Radar's cross-chain staking system.
As the project at hand implements a cross-chain system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that the cross-chain data guarantees desired by the protocol are upheld.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed two cross-chain specific vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Dapp Radar team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 21 findings were identified over the course of the manual review of which 13 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| LAP-01M |  |  | Potentially Undesirable Blockchain Flexibility |
| LAP-02M |  |  | Outdated LayerZero Receiver Implementation |
| SRC-01M | | | Inexistent Synchronization of Pool Rewards |
| SRC-02M | | | Hard-Coded Gas Allowance for Cross-Chain Relay |
| SRC-03M | | | Non-Standard Signature Verification Workflow |
| SRC-04M |  | | Improper Withdrawal Debt Calculation |
| SRP-01M | |  | Inexistent Capability of Native Asset Extraction |
| SRP-02M | | | Inexistent Conformance to Checks-Effects-Interactions Pattern |
| SRP-03M | | | Authoritative Overriddence of Cross-Chain Data Synchrosity |
| SRP-04M | | | Hard-Coded Gas Allowance for Cross-Chain Relay |
| SRP-05M | | | Improper Invocations of EIP-20 transfer |
| SRP-06M | |  | Potentially Incorrect Chain ID |
| SRP-07M | | | Incorrect Withdrawal Relay System |