FaithTribe Code Style Findings

FTE-01C: Redundant Value Assignment

Description:

The default value of a bool is assigned to a contract-level variable.

Example:

Copy
13bool public minted = false;

Recommendation:

We advise the assignment to be omitted as the variable contains that value if left uninitialized.

Alleviation:

The Faith Tribe team considered this exhibit but opted not to apply a remediation for it.

FTE-02C: Redundant Visibility Specifiers

Description:

The linked variables are declared as public yet are meant to be utilized as internally accessible variables.

Example:

Copy
10bytes32 public constant SNAPSHOT_ROLE = keccak256("SNAPSHOT_ROLE");
11bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE");

Recommendation:

We advise them to be set as either private or internal depending on their intended scope.

Alleviation:

The Faith Tribe team considered this exhibit but opted not to apply a remediation for it.