Omniscia Nevermined Audit
DIDRegistryLibrary Static Analysis Findings
DIDRegistryLibrary Static Analysis Findings
DIL-01S: Tautology Clauses
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | DIDRegistryLibrary.sol:L117, L119 |
Description:
The _cap >= 0
and _royalties >= 0
conditionals are tautologies.
Example:
contracts/registry/DIDRegistryLibrary.sol
105function initializeNftConfig(106 DIDRegisterList storage _self,107 bytes32 _did,108 uint256 _cap,109 uint8 _royalties110)111internal112{113 require(_self.didRegisters[_did].owner != address(0), 'DID not stored');114 115 require(!_self.didRegisters[_did].nftInitialized, 'NFTs only can be initialized once');116
117 require(_cap >= 0, 'Cap must be >=0'); // tautology118
119 require(_royalties >= 0 && _royalties < 100, 'Invalid royalties number'); // first clause is tautology120
121 _self.didRegisters[_did].mintCap = _cap;122 _self.didRegisters[_did].royalties = _royalties;123 _self.didRegisters[_did].nftInitialized = true;124}
Recommendation:
We recommend them to be omitted from the codebase as they are redundant.
Alleviation:
The tautology conditionals were removed from the codebase according to our recommendation.