Omniscia Pirex Audit
PirexFees Static Analysis Findings
PirexFees Static Analysis Findings
PFS-01S: Literal Equality of bool Variable
| Type | Severity | Location |
|---|---|---|
| Gas Optimization |  | PirexFees.sol:L75 |
Description:
The linked bool comparison is performed between a variable and a bool literal.
Example:
contracts/PirexFees.sol
75if (hasRole(FEE_DISTRIBUTOR_ROLE, distributor) == false)Recommendation:
We advise the bool variable to be utilized directly either in its negated (!) or original form.
Alleviation:
The Pirex team has stated that they wish to retain the current code in place. We would like to note that this is the boolean-equal static analyser finding of slither, and relates to code style rather than gas optimization. In any case, we consider this exhibit acknowledged as per the Pirex team's request.