Omniscia Qanx Token Audit
QANX Code Style Findings
QANX Code Style Findings
QAN-01C: Inexistent Event Emission
Type | Severity | Location |
---|---|---|
Language Specific | QANX.sol:L72-L75 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/QANX.sol
72function setChequeSigner(address _newChequeSigner) external {73 require(msg.sender == chequeSigner && _newChequeSigner != address(0), "Invalid cheque signer");74 chequeSigner = _newChequeSigner;75}
Recommendation:
We advise an event
to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation:
A ChequeSignerUpdated
event was introduced to the codebase and is now properly emitted in the setChequeSigner
function, alleviating this exhibit in full.