Omniscia Steadefi Audit
Code Style
Code Style
During the manual portion of the audit, we identified 38 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| CLO-01C |  |  | Inefficient mapping Lookups |
| GMD-01C | | | Inefficient Code Repetition |
| GMD-02C | | | Inefficient Token Weight Assessment |
| GMD-03C | | | Loop Iterator Optimizations |
| GMD-04C | | | Repetition of Statements |
| GMD-05C | | | Variable Mutability Specifiers (Immutable) |
| GMP-01C | | | Ineffectual Usage of Safe Arithmetics |
| GMP-02C | | | Repetitive Value Literals |
| GMP-03C | | | Variable Mutability Specifiers (Immutable) |
| GMX-01C | | | Ineffectual Usage of Safe Arithmetics |
| GMX-02C | | | Inefficient Transfer Flow |
| GMX-03C | | | Inexplicable Transfer of Dust |
| GMX-04C | | | Repetitive Value Literal |
| GMX-05C | | | Variable Mutability Specifiers (Immutable) |
| JOE-01C | | | Variable Mutability Specifiers (Immutable) |
| LPL-01C | | | Increase of Fee Function Usability |
| LPL-02C | | | Ineffectual Usage of Safe Arithmetics |
| LPL-03C | | | Inefficient Calculation Offsets |
| LPL-04C | | | Inefficient Calculation of First Interest |
| LPL-05C | | | Inefficient Enforcement of EIP-20 Asset Trait |
| LPL-06C | | | Inefficient Event Emission |
| LPL-07C | | | Inefficient Recalculation of Formulas |
| LPL-08C | | | Inefficient mapping Lookups |
| LPL-09C | |  | Repetitive Value Literal |
| LPL-10C | | | Variable Mutability Specifiers (Immutable) |
| LPC-01C | |  | Ineffectual Usage of Safe Arithmetics |
| LPC-02C | | | Redundant Pre-Calculation of Rate |
| MHT-01C | | | Repetitive Value Literal |
| MHT-02C | | | Suboptimal Delta Evaluation |
| TJM-01C | | | Ineffectual Usage of Safe Arithmetics |
| TJM-02C | | | Variable Mutability Specifiers (Immutable) |
| TJF-01C | | | Ineffectual Usage of Safe Arithmetics |
| TJF-02C | | | Repetitive Value Literal |
| TJF-03C | | | Variable Mutability Specifiers (Immutable) |
| TJY-01C | | | Inefficient Transfer Flow |
| TJY-02C | | | Inexplicable Transfer of Dust |
| TJY-03C | | | Repetitive Value Literal |
| TJY-04C | | | Variable Mutability Specifiers (Immutable) |