Omniscia Sovryn Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the BabelFish implementation by Sovryn.
As the project at hand implements an asset conversion mechanism, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed minor misconceptions within the system which coud lead to misbehaviours arising in its overall operation, however, they were conveyed ahead of time to the Sovryn team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the rationale behind the b-asset (assumed to be BabelFish-asset) and m-asset (unknown) naming convention.
A total of 12 findings were identified over the course of the manual review of which 5 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
BMR-01M | Minor | No | Unaccounted Truncation of Quantity |
IOL-01M | Minor | No | Ownership Pull-Over-Push Pattern |
IRG-01M | Minor | No | Inconsistent Initialization Guard |
OWN-01M | Minor | Yes | Ownership Pull-Over-Push Pattern |
TPA-01M | Minor | Yes | Weak Threshold Validation |