Omniscia Tokemak Audit

ConvexController Manual Review Findings

ConvexController Manual Review Findings

CCR-01M: Non-Inclusive Minimum Amount

Description:

The linked check states that it performs a minAmount validation yet it is a strict greater-than (>) comparison.

Example:

contracts/controllers/ConvexController.sol
116require(balanceChange > expectedRewards[i].minAmount, "BALANCE_MUST_INCREASE");

Recommendation:

We advise it to be set as an inclusive operation to properly act as a minimum value.

Alleviation:

The comparison was properly adjusted to become inclusive (>=) as advised.