Omniscia Tokemak Network Audit

Code Style

Code Style

During the manual portion of the audit, we identified 17 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ARY-01CInformationalYesInefficient Hash Specification
ARY-02CInformationalYesRedundant & Abnormal Assignments
BCE-01CInformationalYesInefficient Data Type
DFN-01CInformationalYesInefficient Hash Specification
EPL-01CInformationalAcknowledgedUnconditional Layer 2 Relay
EPY-01CInformationalYesDeprecated if-revert Pattern
MAN-01CInformationalYesInefficient Hash Specification
MAN-02CInformationalYesInefficient length Querying
POO-01CInformationalAcknowledgedUnconditional Layer 2 Relay
RHH-01CInformationalYesRedundant Default Value Assignment
RMR-01CInformationalAcknowledgedRedundant Application of Access Control
SSC-01CInformationalYesRedundant Evaluation
SCV-01CInformationalYesRedundant Evaluation
TMP-01CInformationalAcknowledgedUnconditional Layer 2 Relay
TVP-01CInformationalAcknowledgedUnconditional Layer 2 Relay
VTR-01CInformationalYesInefficient Hash Specification
VTR-02CInformationalYesInefficient Loop Halt