Omniscia WallFair Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the vesting contract and token of WallFair.

As the project at hand implements a vesting system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that no funds can be extracted prior to their intended release date.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a single design flaw within the system which we strongly recommend the WallFair team to adjust to ensure that all state transitions of the system are sound.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.

A total of 5 findings were identified over the course of the manual review of which 3 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
TLK-01MMediumYesImproper Staking Design
TLK-02MMinorYesInexistent Sanitization of Start Time
TLK-03MMinorYesMisleading Error Message