xfit Static Analysis Findings

XFI-01S: Variable Shadowing

Description:

The constructor of the Xfit contract has input variables whose name collides with variable names found in inherited implementations.

Example:

Copy
9constructor(
10    string memory _name,
11    string memory _symbol,
12    uint256 _amount,
13    address token_holder
14) public ERC20(_name, _symbol) {
15    _mint(token_holder, _amount);
16}

Recommendation:

We advise the input variables to be properly renamed to avoid the variable shadowing issue.The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.