Omniscia DAFI Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 20 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BBO-01CInformationalYesInexistent Error Message
BBO-02CInformationalYesRedundant keccak256 Re-Execution
BBO-03CInformationalNoSuboptimal Conditionals
BBO-04CInformationalYesVariable Mutability Specifiers
DAF-01CInformationalNoInexistent Error Messages
DAF-02CInformationalNoInexistent Visibility Specifiers
DAF-03CInformationalNoSuboptimal Code
DAF-04CInformationalNoVariable Mutability Specifiers
DAI-01CInformationalYesInexistent Visibility Specifiers
DAI-02CInformationalYesSuboptimal Code
DAI-03CInformationalYesVariable Mutability Specifier
EBO-01CInformationalYesInexistent Error Message
EBO-02CInformationalYesRedundant keccak256 Re-Execution
EBO-03CInformationalNoSuboptimal Conditionals
EBO-04CInformationalYesVariable Mutability Specifiers
BAS-01CInformationalYesInexistent Visibility Specifiers
BAS-02CInformationalYesRedundant require Check
OWN-01CInformationalNoVariable Mutability Specifiers
STA-01CInformationalYesRedundant require Checks
STA-02CInformationalYesSuboptimal Code

Prev

Manual Review

Next

BscBridgeOptimized.sol (BBO-S)