Omniscia DAFI Protocol Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the centralized token bridge of the DAFI Protocol.
As the project at hand implements a cross-chain bridge, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a major vulnerability within the system which would make it incompatible with significant tokens, however, it was conveyed ahead of time to the DAFI Protocol team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 27 findings were identified over the course of the manual review of which 7 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
BBO-01M | Medium | Yes | Insecure Elliptic Curve Recovery Mechanism |
BBO-02M | Medium | No | Potential Invalidation of Arbitrary Transactions |
DAF-01M | Minor | No | Potentially Dangerous Evaluation |
DAI-01M | Major | Yes | Inexistent Adjustment of Allowance |
EBO-01M | Major | No | Improper Validation of EIP-20 Transfer |
EBO-02M | Medium | Yes | Insecure Elliptic Curve Recovery Mechanism |
EBO-03M | Medium | No | Potential Invalidation of Arbitrary Transactions |