Omniscia DAFI Audit

Code Style

Code Style

During the manual portion of the audit, we identified 19 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
NDD-01CInformationalYesConvoluted Code
NDD-02CInformationalYesInexistent Visibility Specifiers
NDD-03CInformationalYesVariable Mutability Specifier
PFS-01CInformationalYesVariable Mutability Specifier
REE-01CInformationalNoInexistent Visibility Specifiers
REE-02CInformationalYesRedundant Getter Invocation
REE-03CInformationalYesRedundant Return Value
SDE-01CInformationalYesDuplication of Code
SDE-02CInformationalNoInexistent Visibility Specifiers
SDE-03CInformationalYesLiteral Boolean Comparison
SDE-04CInformationalYesRedundant Function Implementation
SDE-05CInformationalYesRedundant Visibility Specifier
SMV-01CInformationalYesCode Inconsistency
SMV-02CInformationalNoInexistent Visibility Specifiers
SMV-03CInformationalYesRedundant Logic Paths
SMV-04CInformationalYesVariable Mutability Specifier
TVL-01CInformationalYesInexistent Visibility Specifier
TPL-01CInformationalNoType Optimization
TPL-02CInformationalYesVariable Mutability Specifier

Prev

Manual Review

Next

Static Analysis