Omniscia fetchai Audit

DebtBalancer Code Style Findings

DebtBalancer Code Style Findings

DBR-01C: Ineffectual Multiplication

TypeSeverityLocation
Gas OptimizationInformationalDebtBalancer.sol:L271

Description:

The linked statement conducts a multiplication of ONE_UNIT by 1 which will yield ONE_UNIT.

Example:

contracts/ALP/DebtBalancer.sol
271value1ACT = tokenizerContract.calcACTToValue(actId, 1 * (ONE_UNIT));

Recommendation:

We advise the multiplication to be simply omitted from the codebase.

Alleviation:

The multiplication has been safely omitted.