Omniscia fetchai Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the Atomix lending protocol by fetch.ai.
As the project at hand implements a novel lending protocol, intricate care was put into ensuring that the flow of funds and debts within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple major vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the fetch.ai team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 24 findings were identified over the course of the manual review of which 13 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
ALP-01M | Medium | Yes | Privileged Re-Entrancy Attack |
ALP-02M | Minor | Yes | Improper Handling of Zero Values |
ALP-03M | Minor | Yes | Improperly Handled Edge Case |
DBR-01M | Major | Yes | Inexistent Access Control |
ICO-01M | Major | Yes | Inexistent Usage of Safe Arithmetics |
ICO-02M | Minor | Yes | Over Complicated Exponent Approximation |
IMR-01M | Minor | Yes | Accuracy Potentially Low |
LPL-01M | Major | Yes | Inexistent Access Control |
LPL-02M | Minor | Yes | Incorrect WithdrawACT Event Argument |
LPL-03M | Minor | Yes | Potential of Zero Amount Withdrawals |
LLR-01M | Major | Yes | Inexistent Access Control |
PSB-01M | Informational | Yes | Manual Deletion of Struct Members |
RLL-01M | Medium | Yes | Inexistent Usage of Safe Arithmetics |