Omniscia Kanpeki Finance Audit
Code Style
Code Style
During the manual portion of the audit, we identified 15 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BMR-01C | Informational | Yes | Duplicate ERC20 Transfer |
| BMR-02C | Informational | Yes | Out of Date Documentation |
| BMR-03C | Informational | No | Redundant Visibility Specifiers |
| CAS-01C | Informational | Yes | Pre-Calculated Key Lookups |
| CRY-01C | Informational | Yes | Pre-Calculated Key Lookups |
| CRY-02C | Informational | Yes | Redundant Duplicate Mapping Lookups |
| DMR-01C | Informational | No | Redundant Visibility Specifier |
| ORA-01C | Informational | Yes | Improper Failure Execution |
| ORA-02C | Informational | Yes | Potential Value Misconception |
| ORA-03C | Informational | Yes | Redundant Code Duplication |
| PAU-01C | Informational | No | Redundant constructor Implementation |
| RMR-01C | Informational | No | Redundant Visibility Specifier |
| SMR-01C | Informational | No | Redundant Visibility Specifier |
| TOK-01C | Informational | No | Redundant Visibility Specifier |
| TRY-01C | Informational | Yes | Redundant Duplicate Lookup |