Omniscia Kanpeki Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the protocol implementation of Kanpeki Finance.
As the project at hand implements a novel borrowing and lending protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple misbehaviours within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Kanpeki Finance team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a great extent, containing in-line comments and verbose code wherever applicable.
A total of 26 findings were identified over the course of the manual review of which 11 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
BMR-01M | Medium | Yes | Incorrect Repayment of Interest |
CMR-01M | Minor | Yes | Improper Sanitization of Ratios |
CRY-01M | Medium | Yes | Central Point of Failure |
COO-01M | Minor | Yes | Disjoint Settlement Action |
DMR-01M | Medium | Yes | Inexistent Minimum Interest Validation |
FMR-01M | Minor | Yes | Incorrect Fee Discount Assumption |
ORA-01M | Major | Yes | Outdated Chainlink Implementation |
ORA-02M | Minor | Yes | Potentially Incorrect Decimal Assumption |
OWN-01M | Minor | Yes | Pull-Over-Push Ownership Pattern |
RMR-01M | Medium | Yes | Ineffectual Cap Increase |
SMR-01M | Major | Yes | Circumvention of Expected Amount Penalization |