Omniscia Keyko Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the community system by Keyko.

As the project at hand implements a proxy-based system implementation, intricate care was put into ensuring that the execution flow within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed potential misconceptions and misutilizations of external libraries within the system which could have had moderate ramifications to its overall operation, however, they were conveyed ahead of time to the Keyko team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent, containing thorough in-line documentation and comments across the codebase.

A total of 32 findings were identified over the course of the manual review of which 17 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
COM-01MMediumNoImproper Role Management System
COM-02MMediumYesInexistent Prevention of cUSD Transfer
COM-03MMediumYesInexistent Validation of Max Claim & Step Arguments
COM-04MMediumYesPotentially Prohibitive Migration Mechanism
COM-05MMinorYesImpermanent Migration Procedure
COM-06MMinorYesInexistent Initialization of Re-Entrancy Guard
CAI-01MMediumYesOverly Centralized Asset Control
CAI-02MMediumYesPotential Duplication of Community Migration
CAI-03MMinorYesInexistent Initialization of Re-Entrancy Guard
CAI-04MMinorYesInexistent Validation of Community Removal
CAI-05MMinorYesPotentially Incorrect Tranche Calculation
DMI-01MMinorYesPotential Accounting Discrepancy Leading to Halt
DMI-02MMinorYesPotentially Incorrect Initialization Check
IPT-01MMediumYesInsecure Elliptic Curve Recovery Mechanism
ILV-01MMediumYesImproper Last Claim Update
ILV-02MMinorYesPotential Bypass of Vesting
TIN-01MMinorYesInexistent Initialization of Re-Entrancy Guard