Omniscia KlimaDAO Audit
StakingHelper Code Style Findings
StakingHelper Code Style Findings
SHR-01C: Inexistent Error Messages
Type | Severity | Location |
---|---|---|
Code Style | Informational | StakingHelper.sol:L89, L91 |
Description:
The linked require
checks have no error messages explicitly defined.
Example:
contracts/staking/regular/StakingHelper.sol
89require( _staking != address(0) );
Recommendation:
We advise them to be set so to aid in the validation of the require
's condition as well as the legibility of the codebase.
Alleviation:
The KlimaDAO team considered this exhibit but opted to retain the codebase in its current state.