Omniscia KlimaDAO Audit
sKlimaToken_v2 Code Style Findings
sKlimaToken_v2 Code Style Findings
KT2-01C: Inexistent Error Messages
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | sKlimaToken_v2.sol:L999, L1045, L1046, L1058 |
Description:
The linked require checks have no error messages explicitly defined.
Example:
contracts/tokens/regular/sKlimaToken_v2.sol
1044function initialize( address stakingContract_ ) external returns ( bool ) {1045 require( msg.sender == initializer );1046 require( stakingContract_ != address(0) );1047 stakingContract = stakingContract_;1048 _gonBalances[ stakingContract ] = TOTAL_GONS;1049
1050 emit Transfer( address(0x0), stakingContract, _totalSupply );1051 emit LogStakingContractUpdated( stakingContract_ );1052
1053 initializer = address(0);1054 return true;1055}Recommendation:
We advise them to be set so to aid in the validation of the require's condition as well as the legibility of the codebase.
Alleviation:
The KlimaDAO team considered this exhibit but opted to retain the codebase in its current state.