Omniscia Platypus Finance Audit

Code Style

Code Style

During the manual portion of the audit, we identified 17 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
GAA-01CInformationalNoInefficient Mutability Type
GAA-02CInformationalNoRedundant Default Value Assignments
MPS-01CInformationalYesInexistent Error Messages
MPS-02CInformationalNoVariable Mutability Specifiers
PTP-01CInformationalNoDeprecated Representation Style
PTP-02CInformationalYesInefficient Mutability Type
PTP-03CInformationalYesMemory Usage Optimization
PTP-04CInformationalNoRedundant Usage of SafeMath
TIM-01CInformationalNoRedundant Usage of SafeMath
TVG-01CInformationalNoRedundant User-Defined Getters
VER-01CInformationalNoNon-Standard Aftercall Hook
VPP-01CInformationalNoDuplicate Inheritence
VPP-02CInformationalYesNon-Standard Assertion Pattern
VPP-03CInformationalYesRedundant Evaluation
VPP-04CInformationalNoVariable Mutability Specifier
WHI-01CInformationalYesRedundant User-Defined Getter
WHI-02CInformationalYesRedundant constructor Implementation