Omniscia Polkadex Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the PDEX token.
As the project at hand implements an ERC20 token, intricate care was put into ensuring that the token implementation is fully compliant with the ERC20 standard.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed several style issues within the system which we believe can significantly increase the code's legibility. Additinoally, we pointed out a best practice with regards to the contract's ownership which we urge the Polkadex team to adopt.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the vesting segment distributions.
A total of 3 findings were identified over the course of the manual review of which 1 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
DEX-01M | Minor | No | Pull-Over-Push Pattern |