Omniscia Alliance Block Audit
NonCompoundingRewardsPool Static Analysis Findings
NonCompoundingRewardsPool Static Analysis Findings
NCR-01S: Variable Shadowing
| Type | Severity | Location |
|---|---|---|
| Language Specific | Minor | NonCompoundingRewardsPool.sol:L20-L21 |
Description:
The linked variables shadow the homonymous variable declarations of ThrottledExitFeature.
Example:
contracts/V2/NonCompoundingRewardsPool.sol
19uint256 _stakeLimit,20uint256 throttleRoundBlocks,21uint256 throttleRoundCap,22address _treasury,23address _externalRewardTokenRecommendation:
We advise that the shadowing is alleviated by prefixing the linked variables with the underscore (_) character.
Alleviation:
The variable shadowing was removed from the codebase by prefixing the input variables with an underscore (_).