Omniscia Alliance Block Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Alliance Block's subscription, session and verification portals.
As the project at hand implements validation callbacks meant to conform to the Rain Protocol implementation, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that the code is compliant with the external standards it is meant to fulfill.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed an important access control flaw within the system which could have had severe ramifications to its overall operation, however, it was conveyed ahead of time to the Alliance Block team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent.
A total of 10 findings were identified over the course of the manual review of which 7 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
SPP-01M | Incorrectly Calculated TKN Amount | ||
SPT-01M | Slightly Inaccurate Documentation | ||
CON-01M | Incorrect Enforcement of Extension Factor | ||
CON-02M | Incorrectly Calculated TKN Amount | ||
USD-01M | Inexplicable Centralization of Oracle Management | ||
VPP-01M | Unconsumed Token Limits | ||
VPP-02M | Inexistent Access Control of Approve Hook |