Omniscia Arcade Protocol Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Arcade Protocol's migration contracts.

As the project at hand implements special-purpose migration systems, intricate care was put into ensuring that the flow of funds & assets within the system conforms to the specifications and restrictions laid forth within the protocol's V2 and V3 specifications.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed two race-condition vulnerabilities of the same nature within the system which could have had severe ramifications to its overall operation; we urge the Arcade Protocol team to promptly remediate them.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent, containing extensive in-line documentation within the implementations as well as interfaces of the contracts.

A total of 10 findings were identified over the course of the manual review of which 7 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
VTV-01MInexplicable Implementation of Receive Function
VTV-02MPotentially Out-of-Sync Literal
VTV-03MImproper Consumption of Flash-Loan Calls
VTR-01MIll-Advised Toggle Mechanism
VTW-01MInexplicable Implementation of Receive Function
VTW-02MPotentially Out-of-Sync Literal
VTW-03MImproper Consumption of Flash-Loan Calls